irqchip/bcm-6345-l1: Prefer struct_size)_ over open coded arithmetic
authorErick Archer <erick.archer@gmx.com>
Fri, 9 Feb 2024 18:16:00 +0000 (19:16 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 13 Feb 2024 09:53:15 +0000 (10:53 +0100)
commit004c7a6bf43edbd4b092fb6ebba8991d56bc3428
treec081ad22c173a45a396c16908c6ee9be25ec83ae
parent83c0708719f77018cd3b98b0011c9526a3e0e2ca
irqchip/bcm-6345-l1: Prefer struct_size)_ over open coded arithmetic

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows.

The cpu variable is a pointer to "struct bcm6345_l1_cpu" and this structure
ends in a flexible array:

struct bcm6345_l1_cpu {
[...]
u32 enable_cache[];
};

The preferred way in the kernel is to use the struct_size() helper to do
the arithmetic instead of the argument "size + count * size" in the
kzalloc() function.

This way, the code is more readable and safer.

Signed-off-by: Erick Archer <erick.archer@gmx.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20240209181600.9472-1-erick.archer@gmx.com
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/162
drivers/irqchip/irq-bcm6345-l1.c