scsi: sd: Unregister device if device_add_disk() failed in sd_probe()
authorLi Nan <linan122@huawei.com>
Fri, 8 Dec 2023 08:23:35 +0000 (16:23 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 2 Apr 2024 01:26:16 +0000 (21:26 -0400)
commit0296bea01cfa6526be6bd2d16dc83b4e7f1af91f
tree08b532c8686e2a3116a2cf40d611897ae9e04b57
parent6bc5e70b1c792b31b497e48b4668a9a2909aca0d
scsi: sd: Unregister device if device_add_disk() failed in sd_probe()

"if device_add() succeeds, you should call device_del() when you want to
get rid of it."

In sd_probe(), device_add_disk() fails when device_add() has already
succeeded, so change put_device() to device_unregister() to ensure device
resources are released.

Fixes: 2a7a891f4c40 ("scsi: sd: Add error handling support for add_disk()")
Signed-off-by: Li Nan <linan122@huawei.com>
Link: https://lore.kernel.org/r/20231208082335.1754205-1-linan666@huaweicloud.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c