perf/x86/intel/uncore: Fix reference count leak in __uncore_imc_init_box()
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Fri, 18 Nov 2022 06:31:37 +0000 (14:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:02 +0000 (13:14 +0100)
commit0358bc7cc21ad972a06918f3cf2222dc40127cb8
tree904f371999f188eabe430dc6d58c3add5a46d104
parent433bd587dca5c3f7157fef2fe571290cd392cbf6
perf/x86/intel/uncore: Fix reference count leak in __uncore_imc_init_box()

[ Upstream commit 17b8d847b92d815d1638f0de154654081d66b281 ]

pci_get_device() will increase the reference count for the returned
pci_dev, so tgl_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count before exiting from __uncore_imc_init_box(). Add
pci_dev_put() for both normal and error path.

Fixes: fdb64822443e ("perf/x86: Add Intel Tiger Lake uncore support")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-5-wangxiongfeng2@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/events/intel/uncore_snb.c