thermal: intel: int340x_thermal: replace deprecated strncpy() with strscpy()
authorJustin Stitt <justinstitt@google.com>
Mon, 18 Mar 2024 22:36:10 +0000 (22:36 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 27 Mar 2024 13:57:44 +0000 (14:57 +0100)
commit03fa9a3ad1d61992a2105aeb1062b349f1a85012
tree7cb6a16bde2f279807ff9afbcdfa000dd535243a
parentb33f3d2677b8ddd7a3aba2b02497422a1d2c2a01
thermal: intel: int340x_thermal: replace deprecated strncpy() with strscpy()

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

psvt->limit.string can only be 8 bytes so let's use the appropriate size
macro ACPI_LIMIT_STR_MAX_LEN.

Neither psvt->limit.string or psvt_user[i].limit.string requires the
NUL-padding behavior that strncpy() provides as they have both been
filled with NUL-bytes prior to the string operation.
| memset(&psvt->limit, 0, sizeof(u64));
and
|  psvt_user = kzalloc(psvt_len, GFP_KERNEL);

Let's use `strscpy` [2] due to the fact that it guarantees
NUL-termination on the destination buffer without unnecessarily
NUL-padding.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c