eventfs: Add WARN_ON_ONCE() to checks in eventfs_root_lookup()
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 1 Feb 2024 17:33:46 +0000 (12:33 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Sun, 17 Mar 2024 11:58:52 +0000 (07:58 -0400)
commit04204cd9b0b450bfe561a5f8d0fc91288c6427ab
treea57457cc74ec5e2fa297bd4d51e1415e62f9b80d
parent63bd30f249dcf0a7ce16967935cecee8feec24bb
eventfs: Add WARN_ON_ONCE() to checks in eventfs_root_lookup()

There's a couple of if statements in eventfs_root_lookup() that should
never be true. Instead of removing them, add WARN_ON_ONCE() around them.

  One is a tracefs_inode not being for eventfs.

  The other is a child being freed but still on the parent's children
  list. When a child is freed, it is removed from the list under the
  same mutex that is held during the iteration.

Link: https://lore.kernel.org/linux-trace-kernel/20240201002719.GS2087318@ZenIV/
Link: https://lore.kernel.org/linux-trace-kernel/20240201123346.724afa46@gandalf.local.home
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ajay Kaher <ajay.kaher@broadcom.com>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
fs/tracefs/event_inode.c