scsi: ufs: core: Let the sq_lock protect sq_tail_slot access
authorCan Guo <quic_cang@quicinc.com>
Mon, 18 Dec 2023 15:32:17 +0000 (07:32 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Dec 2023 02:09:54 +0000 (21:09 -0500)
commit04c116e2bdfc3969f9819d2cebfdf678353c354c
treefd2f09ebf811e55e284bb73a67a3abcc14c40ebf
parent9264fd61e628ce180a168e6b90bde134dd49ec28
scsi: ufs: core: Let the sq_lock protect sq_tail_slot access

When accessing sq_tail_slot without protection from sq_lock, a race
condition can cause multiple SQEs to be copied to duplicate SQE slots. This
can lead to multiple stability issues. Fix this by moving the *dest
initialization in ufshcd_send_command() back under protection from the
sq_lock.

Fixes: 3c85f087faec ("scsi: ufs: mcq: Use pointer arithmetic in ufshcd_send_command()")
Signed-off-by: Can Guo <quic_cang@quicinc.com>
Link: https://lore.kernel.org/r/1702913550-20631-1-git-send-email-quic_cang@quicinc.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c