drm/xe: Invert mask and val in xe_mmio_wait32.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 26 Jul 2023 21:03:52 +0000 (17:03 -0400)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:39:15 +0000 (11:39 -0500)
commit063e09af6e1d9a4f26cdd0eb896c19526cb0afd3
tree45f5d92bd4ef69d512ce6d6fef66f5f608f6015f
parentf83a30f466ebbd56355b1f65ec9bcd5087840ffc
drm/xe: Invert mask and val in xe_mmio_wait32.

The order: 'offset, mask, val'; is more common in other
drivers and in special in i915, where any dev could copy
a sequence and end up with unexpected behavior.

Done with coccinelle:
@rule1@
expression gt, reg, val, mask, timeout, out, atomic;
@@
- xe_mmio_wait32(gt, reg, val, mask, timeout, out, atomic)
+ xe_mmio_wait32(gt, reg, mask, val, timeout, out, atomic)

spatch -sp_file mmio.cocci *.c *.h compat-i915-headers/intel_uncore.h \
       --in-place

v2: Rebased after changes on xe_guc_mcr usage of xe_mmio_wait32.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_force_wake.c
drivers/gpu/drm/xe/xe_gt.c
drivers/gpu/drm/xe/xe_guc.c
drivers/gpu/drm/xe/xe_huc.c
drivers/gpu/drm/xe/xe_mmio.h
drivers/gpu/drm/xe/xe_pcode.c
drivers/gpu/drm/xe/xe_uc_fw.c