serial: pch: Remove eg20t_port::lock.
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Fri, 1 Mar 2024 21:45:30 +0000 (22:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 Mar 2024 21:06:22 +0000 (22:06 +0100)
commit06d28ca0c66cbb4e3716454f365f9cbb1e57a681
treec9817e4e5d9f0a2b9c1eddc69a746657acb03968
parent38f3fc2e82a03d6dbb30c1fecacc630bd0ac9c28
serial: pch: Remove eg20t_port::lock.

The struct eg20t_port has a spinlock_t which is used for locking while
access I/O of the device. Then there is the uart_portlock which is
sometimes and nests within eg20t_port's lock.

The uart_port lock is not used while using the struct in
pch_uart_hal_read() which might be okay. Then both locks are used in
pch_console_write() which looks odd especially the double try_lock part.

All in all it looks like the uart_port's lock could replace eg20t_port's
lock and simplify the code.

Remove eg20t_port::lock and use uart_port's lock for the lock scope.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20240301215246.891055-18-bigeasy@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pch_uart.c