platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo
authorAvadhut Naik <Avadhut.Naik@amd.com>
Thu, 16 Nov 2023 22:47:24 +0000 (16:47 -0600)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 21 Nov 2023 20:10:44 +0000 (21:10 +0100)
commit0706526ec7704dcd046239078ac175d11a88a95e
tree44aa28ecff9ea8e09a7b3dd3cc48f972fef840dc
parent71cd3c636404ceb08226b5095ca36a04eb578ca1
platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo

The debugfs_create_blob() function has been used to create read-only binary
blobs in debugfs. The function filters out permissions, other than S_IRUSR,
S_IRGRP and S_IROTH, provided while creating the blobs.

The very behavior though is being changed through previous patch in the
series (fs: debugfs: Add write functionality to debugfs blobs) which makes
the binary blobs writable by owners. Thus, all permissions provided while
creating the blobs, except S_IRUSR,S_IWUSR, S_IRGRP, S_IROTH, will be
filtered by debugfs_create_blob().

As such, rectify the permissions of panicinfo file since the S_IFREG flag
was anyways being filtered out by debugfs_create_blob(). Moreover, the
very flag will always be set be set for the panicinfo file through
__debugfs_create_file().

Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/platform/chrome/cros_ec_debugfs.c