hw/vfio/container: Fix SIGSEV on vfio_container_instance_finalize()
authorEric Auger <eric.auger@redhat.com>
Fri, 19 Jul 2024 16:50:11 +0000 (18:50 +0200)
committerCédric Le Goater <clg@redhat.com>
Tue, 23 Jul 2024 15:14:52 +0000 (17:14 +0200)
commit07321a6d087d4ec9866cfb0c8b53692a59758976
tree84e4356267085e55d32fbb01c0869428be2fe92f
parent3cce8bd4d737f2ca688bbdcb92cd5cc683245bbd
hw/vfio/container: Fix SIGSEV on vfio_container_instance_finalize()

In vfio_connect_container's error path, the base container is
removed twice form the VFIOAddressSpace QLIST: first on the
listener_release_exit label and second, on free_container_exit
label, through object_unref(container), which calls
vfio_container_instance_finalize().

Let's remove the first instance.

Fixes: 938026053f4 ("vfio/container: Switch to QOM")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
hw/vfio/container.c