selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior
authorJohn Stultz <jstultz@google.com>
Tue, 9 Apr 2024 20:22:12 +0000 (13:22 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 10 Apr 2024 20:07:42 +0000 (22:07 +0200)
commit076361362122a6d8a4c45f172ced5576b2d4a50d
treefe3a21d7c7ce89eb6bffe6e545a4fdd60c4d89b1
parent5284984a4fbacb0883bfebe905902cdda2891a07
selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior

The struct adjtimex freq field takes a signed value who's units are in
shifted (<<16) parts-per-million.

Unfortunately for negative adjustments, the straightforward use of:

  freq = ppm << 16 trips undefined behavior warnings with clang:

valid-adjtimex.c:66:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
        -499<<16,
        ~~~~^
valid-adjtimex.c:67:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
        -450<<16,
        ~~~~^
..

Fix it by using a multiply by (1 << 16) instead of shifting negative values
in the valid-adjtimex test case. Align the values for better readability.

Reported-by: Lee Jones <joneslee@google.com>
Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/20240409202222.2830476-1-jstultz@google.com
Link: https://lore.kernel.org/lkml/0c6d4f0d-2064-4444-986b-1d1ed782135f@collabora.com/
tools/testing/selftests/timers/valid-adjtimex.c