init: replace deprecated strncpy with strscpy_pad
authorJustin Stitt <justinstitt@google.com>
Tue, 2 Apr 2024 20:39:49 +0000 (20:39 +0000)
committerKees Cook <keescook@chromium.org>
Tue, 30 Apr 2024 17:34:29 +0000 (10:34 -0700)
commit07f8230b4b39b8b7fb401a67f308c61a43542402
tree761d9094a12371ac60e63144e7acb8f7db557fa1
parent998b18072ceb0613629c256b409f4d299829c7ec
init: replace deprecated strncpy with strscpy_pad

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

data_page wants to be NUL-terminated and NUL-padded, use strscpy_pad to
provide both of these. data_page no longer awkwardly relies on
init_mount to perform its NUL-termination, although that sanity check is
left unchanged.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: <linux-hardening@vger.kernel.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20240402-strncpy-init-do_mounts-c-v1-1-e16d7bc20974@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
init/do_mounts.c