smackfs: Fix use-after-free in netlbl_catmap_walk()
authorPawan Gupta <pawan.kumar.gupta@linux.intel.com>
Sun, 29 Aug 2021 06:41:40 +0000 (23:41 -0700)
committerCasey Schaufler <casey@schaufler-ca.com>
Wed, 15 Sep 2021 23:42:25 +0000 (16:42 -0700)
commit0817534ff9ea809fac1322c5c8c574be8483ea57
treea76cf7ab4439063bbeb1620c50cf6a9c7ec5f1d5
parent6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
smackfs: Fix use-after-free in netlbl_catmap_walk()

Syzkaller reported use-after-free bug as described in [1]. The bug is
triggered when smk_set_cipso() tries to free stale category bitmaps
while there are concurrent reader(s) using the same bitmaps.

Wait for RCU grace period to finish before freeing the category bitmaps
in smk_set_cipso(). This makes sure that there are no more readers using
the stale bitmaps and freeing them should be safe.

[1] https://lore.kernel.org/netdev/000000000000a814c505ca657a4e@google.com/

Reported-by: syzbot+3f91de0b813cc3d19a80@syzkaller.appspotmail.com
Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smackfs.c