xfs: fix uninitialized error variable
authorColin Ian King <colin.king@canonical.com>
Thu, 21 Feb 2019 15:53:20 +0000 (07:53 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 21 Feb 2019 15:55:07 +0000 (07:55 -0800)
commit081a8ae2a54e85ddd77db77d50b1a04b3c4731c9
tree16eb799bac083c1fda2479411ab32668c51f0b84
parent66ae56a53f0e34113da1a70068422b9444fe66f0
xfs: fix uninitialized error variable

A previous commit removed the initialization of variable 'error' to zero,
and can cause a bogus error return.  This occurs when error contains a
non-zero garbage value and the call to xchk_should_terminate detects a
pending fatal signal and checks for a zero error before setting it
to -EAGAIN. Fix the issue by initializing error to zero.

Fixes: b9454fe056bd ("xfs: clean up the inode cluster checking in the inobt scrub")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/scrub/ialloc.c