crypto: nitrox - avoid double free on error path in nitrox_sriov_init()
authorNatalia Petrova <n.petrova@fintech.ru>
Wed, 28 Sep 2022 10:25:05 +0000 (13:25 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 21 Oct 2022 11:15:35 +0000 (19:15 +0800)
commit094528b6a5a755b1195a01e10b13597d67d1a0e6
treeb46b5920458234f45b44d0861c9bf5f6485004c3
parent375de984a3cb691a0bbaf9756e8595e0b54e27e0
crypto: nitrox - avoid double free on error path in nitrox_sriov_init()

If alloc_workqueue() fails in nitrox_mbox_init() it deallocates
ndev->iov.vfdev and returns error code, but then nitrox_sriov_init()
calls nitrox_sriov_cleanup() where ndev->iov.vfdev is deallocated
again.

Fix this by nulling ndev->iov.vfdev after the first deallocation.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 9e5de3e06e54 ("crypto: cavium/nitrox - Add mailbox...")
Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/nitrox/nitrox_mbx.c