gre: Don't accidentally set RTO_ONLINK in gre_fill_metadata_dst()
authorGuillaume Nault <gnault@redhat.com>
Mon, 10 Jan 2022 13:43:09 +0000 (14:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:05:36 +0000 (11:05 +0100)
commit09c0535c768de9429a15c522007dfc8e96a428f8
treec1a26fe949315cf5f67a88fae2af0cdcc634776d
parent63bc14d6e2615e9f89f7110c97ad6e6433379007
gre: Don't accidentally set RTO_ONLINK in gre_fill_metadata_dst()

commit f7716b318568b22fbf0e3be99279a979e217cf71 upstream.

Mask the ECN bits before initialising ->flowi4_tos. The tunnel key may
have the last ECN bit set, which will interfere with the route lookup
process as ip_route_output_key_hash() interpretes this bit specially
(to restrict the route scope).

Found by code inspection, compile tested only.

Fixes: 962924fa2b7a ("ip_gre: Refactor collect metatdata mode tunnel xmit to ip_md_tunnel_xmit")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/ip_gre.c