block: clean up bdrv_drain_all() throttling comments
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 26 Nov 2013 15:18:00 +0000 (16:18 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 6 Dec 2013 15:53:51 +0000 (16:53 +0100)
commit0b06ef3bdd17742ae50c0662d3fe8ed944648890
tree536df3da25a5f0180b527122ffb5396d6815354c
parentac95acdb8e0876fa489bd31a48e8ecd6ef901d67
block: clean up bdrv_drain_all() throttling comments

Since cc0681c45430a1f1a4c2d06e9499b7775afc9a18 ("block: Enable the new
throttling code in the block layer.") bdrv_drain_all() no longer spins.
The code used to look as follows:

  do {
      busy = qemu_aio_wait();

      /* FIXME: We do not have timer support here, so this is effectively
       * a busy wait.
       */
      QTAILQ_FOREACH(bs, &bdrv_states, list) {
          while (qemu_co_enter_next(&bs->throttled_reqs)) {
              busy = true;
          }
      }
  } while (busy);

Note that throttle requests are kicked but I/O throttling limits are
still in effect.  The loop spins until the vm_clock time allows the
request to make progress and complete.

The new throttling code introduced bdrv_start_throttled_reqs().  This
function not only kicks throttled requests but also temporarily disables
throttling so requests can run.

The outdated FIXME comment can be removed.  Also drop the busy = true
assignment since we overwrite it immediately afterwards.

Reviewed-by: Alex Bligh <alex@alex.org.uk>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c