kunit: tool: stop using bare asserts in unit test
authorDaniel Latypov <dlatypov@google.com>
Wed, 2 Dec 2020 19:08:22 +0000 (11:08 -0800)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 8 Feb 2021 22:34:50 +0000 (15:34 -0700)
commit0b3e68076bb9a8e1b1bd448994b9c57828173d8e
tree0b5ec6c2edef6fd01a68083c8b44f5c5a76dcc84
parentcfd607e43da4a20753744f134e201310262b827a
kunit: tool: stop using bare asserts in unit test

Use self.assertEqual/assertNotEqual() instead.
Besides being more appropriate in a unit test, it'll also give a better
error message by show the unexpected values.

Also
* Delete redundant check of exception types. self.assertRaises does this.
* s/kall/call. There's no reason to name it this way.
  * This is probably a misunderstanding from the docs which uses it
  since `mock.call` is in scope as `call`.

Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>
Acked-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/kunit/kunit_tool_test.py