net: tls: fix possible race condition between do_tls_getsockopt_conf() and do_tls_set...
authorHangyu Hua <hbh25y@gmail.com>
Thu, 23 Mar 2023 00:54:40 +0000 (00:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2023 10:47:43 +0000 (12:47 +0200)
commit0b54d75aa43a1edebc8a3770901f5c3557ee0daa
tree8010eed93059dfd0a6c8131c8d5cce69275f9b5f
parent2ebe231abaf1a92fde0539f7e12f09d24b0bf228
net: tls: fix possible race condition between do_tls_getsockopt_conf() and do_tls_setsockopt_conf()

commit 49c47cc21b5b7a3d8deb18fc57b0aa2ab1286962 upstream.

ctx->crypto_send.info is not protected by lock_sock in
do_tls_getsockopt_conf(). A race condition between do_tls_getsockopt_conf()
and error paths of do_tls_setsockopt_conf() may lead to a use-after-free
or null-deref.

More discussion:  https://lore.kernel.org/all/Y/ht6gQL+u6fj3dG@hog/

Fixes: 3c4d7559159b ("tls: kernel TLS support")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20230228023344.9623-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Meena Shanmugam <meenashanmugam@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tls/tls_main.c