nfsd: allow fh_want_write to be called twice
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 12 Apr 2019 20:37:30 +0000 (16:37 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 24 Apr 2019 13:46:35 +0000 (09:46 -0400)
commit0b8f62625dc309651d0efcb6a6247c933acd8b45
tree3f059f6a586a7bcfeaed62896fdd50933aa1ddcb
parente45d1a1835b889676374fb74ff4d0e6b06ad173f
nfsd: allow fh_want_write to be called twice

A fuzzer recently triggered lockdep warnings about potential sb_writers
deadlocks caused by fh_want_write().

Looks like we aren't careful to pair each fh_want_write() with an
fh_drop_write().

It's not normally a problem since fh_put() will call fh_drop_write() for
us.  And was OK for NFSv3 where we'd do one operation that might call
fh_want_write(), and then put the filehandle.

But an NFSv4 protocol fuzzer can do weird things like call unlink twice
in a compound, and then we get into trouble.

I'm a little worried about this approach of just leaving everything to
fh_put().  But I think there are probably a lot of
fh_want_write()/fh_drop_write() imbalances so for now I think we need it
to be more forgiving.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/vfs.h