btrfs: forbid creating subvol qgroups
authorBoris Burkov <boris@bur.io>
Thu, 11 Jan 2024 01:51:26 +0000 (17:51 -0800)
committerDavid Sterba <dsterba@suse.com>
Wed, 31 Jan 2024 07:42:44 +0000 (08:42 +0100)
commit0c309d66dacddf8ce939b891d9ead4a8e21ad6f0
tree96e92fd2d56db9332cbc07a8b7d71212db52be1b
parentf884a9f9e59206a2d41f265e7e403f080d10b493
btrfs: forbid creating subvol qgroups

Creating a qgroup 0/subvolid leads to various races and it isn't
helpful, because you can't specify a subvol id when creating a subvol,
so you can't be sure it will be the right one. Any requirements on the
automatic subvol can be gratified by using a higher level qgroup and the
inheritance parameters of subvol creation.

Fixes: cecbb533b5fc ("btrfs: record simple quota deltas in delayed refs")
CC: stable@vger.kernel.org # 4.14+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ioctl.c