firmware: qcom_scm: disable clocks if qcom_scm_bw_enable() fails
authorGabor Juhos <j4g8y7@gmail.com>
Mon, 4 Mar 2024 13:14:53 +0000 (14:14 +0100)
committerBjorn Andersson <andersson@kernel.org>
Sat, 16 Mar 2024 17:59:42 +0000 (12:59 -0500)
commit0c50b7fcf2773b4853e83fc15aba1a196ba95966
tree5dcfe9c0f8399c577074933d528b88472f22d7f1
parent9f378a62164cfe218b5a355696464d93b132edfb
firmware: qcom_scm: disable clocks if qcom_scm_bw_enable() fails

There are several functions which are calling qcom_scm_bw_enable()
then returns immediately if the call fails and leaves the clocks
enabled.

Change the code of these functions to disable clocks when the
qcom_scm_bw_enable() call fails. This also fixes a possible dma
buffer leak in the qcom_scm_pas_init_image() function.

Compile tested only due to lack of hardware with interconnect
support.

Cc: stable@vger.kernel.org
Fixes: 65b7ebda5028 ("firmware: qcom_scm: Add bw voting support to the SCM interface")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
Link: https://lore.kernel.org/r/20240304-qcom-scm-disable-clk-v1-1-b36e51577ca1@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_scm.c