net: bcmasp: remove eee_enabled/eee_active in bcmasp_get_eee()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 4 Feb 2024 12:13:22 +0000 (12:13 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 7 Feb 2024 17:03:38 +0000 (09:03 -0800)
commit0cbfdfe3fb806e90e9c146974b250d7227f26790
treec8820b7f3092cf644abbd7aeeb85bff50d20a8f5
parent409359c1c2ef30788477b150c8837d8714117d13
net: bcmasp: remove eee_enabled/eee_active in bcmasp_get_eee()

bcmasp_get_eee() sets edata->eee_active and edata->eee_enabled from
its own copy, and then calls phy_ethtool_get_eee() which in turn will
call genphy_c45_ethtool_get_eee().

genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active
with its own interpretation from the PHYs settings and negotiation
result.

Therefore, setting these members in bcmasp_get_eee() is redundant, and
can be removed. This also makes intf->eee.eee_active unnecessary, so
remove this and use a local variable where appropriate.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/E1rWbNC-002cCt-W7@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c
drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c