ceph: fix invalid pointer access if get_quota_realm return ERR_PTR
authorWenchao Hao <haowenchao2@huawei.com>
Thu, 23 Nov 2023 01:53:40 +0000 (09:53 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 15 Jan 2024 14:40:51 +0000 (15:40 +0100)
commit0f4cf64eabc6e16cfc2704f1960e82dc79d91c8d
tree9544fd3a9f4996f25778a70bc47a2c4c23da4c9a
parentb36b03344f5fccb81e5cf3b3ede68b7e7a7e930a
ceph: fix invalid pointer access if get_quota_realm return ERR_PTR

This issue is reported by smatch that get_quota_realm() might return
ERR_PTR but we did not handle it. It's not a immediate bug, while we
still should address it to avoid potential bugs if get_quota_realm()
is changed to return other ERR_PTR in future.

Set ceph_snap_realm's pointer in get_quota_realm()'s to address this
issue, the pointer would be set to NULL if get_quota_realm() failed
to get struct ceph_snap_realm, so no ERR_PTR would happen any more.

[ xiubli: minor code style clean up ]

Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/quota.c