cpufreq: Replace deprecated strncpy() with strscpy()
authorJustin Stitt <justinstitt@google.com>
Wed, 13 Sep 2023 00:07:21 +0000 (00:07 +0000)
committerKees Cook <keescook@chromium.org>
Fri, 29 Sep 2023 21:48:31 +0000 (14:48 -0700)
commit0faf84caee63a5f331bda130265fdceb7d4101b5
tree68f50c99df1e468d6c755c46e3aa5cbe33638c62
parentde055e6116742291a31a21a10108d426574988ff
cpufreq: Replace deprecated strncpy() with strscpy()

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

We should prefer more robust and less ambiguous string interfaces.

Both `policy->last_governor` and `default_governor` are expected to be
NUL-terminated which is shown by their heavy usage with other string
apis like `strcmp`.

A suitable replacement is `strscpy` [2] due to the fact that it guarantees
NUL-termination on the destination buffer.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20230913-strncpy-drivers-cpufreq-cpufreq-c-v1-1-f1608bfeff63@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
drivers/cpufreq/cpufreq.c