soc: qcom-geni-se: Don't use relaxed writes when writing commands
authorDouglas Anderson <dianders@chromium.org>
Wed, 22 Jul 2020 22:01:20 +0000 (15:01 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 10 Sep 2020 16:55:00 +0000 (16:55 +0000)
commit0feea33d79825d05b5ede30947db4df34722b463
treee12f1a1aee2954e7a6731e997e7c4cbfdee7463f
parentcb8aed7b92f3cf74007a07c17bb08e6488661ae9
soc: qcom-geni-se: Don't use relaxed writes when writing commands

Writing the command is the final step in kicking off a transfer.
Let's use writel() to ensure that any other memory accesses are done
before the command kicks off.  It's expected that this is mostly
relevant if we're in DMA mode but since it doesn't appear to regress
performance in a measurable way [1] even in PIO mode and it's easier
to reason about then let's just always use it.

NOTE: this patch came about due to code inspection.  No actual
problems were observed that this patch fixes.

[1] Tested by timing "flashrom -p ec" on a Chromebook which stresses
GENI SPI a lot.

Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Suggested-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200722150113.1.Ia50ab5cb8a6d3a73d302e6bdc25542d48ffd27f4@changeid
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
include/linux/qcom-geni-se.h