media: cros-ec-cec: Don't exit early in .remove() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 26 Mar 2023 14:30:29 +0000 (16:30 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 11 Apr 2023 14:59:13 +0000 (16:59 +0200)
commit0ff7aee24e47beb4306ce050824b54147f2fabfa
tree4e119ff01dc0367ab49ae75682a545a8f1911b77
parent4948ea58e7335e00d6556f884151b0dae1fb344f
media: cros-ec-cec: Don't exit early in .remove() callback

Exiting early in remove without releasing all acquired resources yields
leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
.remove() returns, even if the return code was negative.

While blocking_notifier_chain_unregister() won't fail and so the
change is somewhat cosmetic, platform driver's .remove callbacks are
about to be converted to return void. To prepare that, keep the error
message but don't return early.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/cec/platform/cros-ec/cros-ec-cec.c