target/mips: simplify gen_compute_imm_branch logic
authorAlex Bennée <alex.bennee@linaro.org>
Wed, 9 Sep 2020 11:27:35 +0000 (12:27 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Thu, 10 Sep 2020 09:43:57 +0000 (10:43 +0100)
commit102661430cae403ce8cc5768f1a55512c92234be
treecabe6862a8734e24297d647e71e893a10aa14482
parent7f808687448d767e5f336c1e28e58fe112d72a8c
target/mips: simplify gen_compute_imm_branch logic

One of the Travis builds was complaining about:

  qemu/include/tcg/tcg.h:437:12: error: ‘cond’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
       return (TCGCond)(c ^ 1);
  ../target/mips/translate.c:20031:13: note: ‘cond’ was declared here
       TCGCond cond;

Rather than figure out exactly which one was causing the complaint I
just defaulted to TCG_COND_ALWAYS and allowed that state to double up
for the now defunct bcond_compute variable.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200909112742.25730-5-alex.bennee@linaro.org>
target/mips/translate.c