dm ioctl: structs and parameter strings must not overlap
authorDemi Marie Obenour <demi@invisiblethingslab.com>
Sat, 3 Jun 2023 14:52:41 +0000 (10:52 -0400)
committerMike Snitzer <snitzer@kernel.org>
Fri, 23 Jun 2023 14:31:51 +0000 (10:31 -0400)
commit10655c7a48570315343fdd9cc6acb261d57c2c7a
tree737ca49322e11ed9dffdd85ef5f9033f125a4985
parent13f4a697f8b4feb705569f9336127e9e2f9ac596
dm ioctl: structs and parameter strings must not overlap

The NUL terminator for each target parameter string must precede the
following 'struct dm_target_spec'.  Otherwise, dm_split_args() might
corrupt this struct.  Furthermore, the first 'struct dm_target_spec'
must come after the 'struct dm_ioctl', as if it overlaps too much
dm_split_args() could corrupt the 'struct dm_ioctl'.

Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-ioctl.c