soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications
authorDouglas Anderson <dianders@chromium.org>
Mon, 4 May 2020 17:50:15 +0000 (10:50 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Fri, 15 May 2020 18:42:29 +0000 (11:42 -0700)
commit1143c36656b8dccf0ece93053502a147d3c60961
treee0cf896d5f1c7dfb70055b456f400a7a4352f19b
parentc20977721631602eafb263fd89fbafaa11de1ebe
soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications

Our switch statement doesn't have entries for CPU_CLUSTER_PM_ENTER,
CPU_CLUSTER_PM_ENTER_FAILED, and CPU_CLUSTER_PM_EXIT and doesn't have
a default.  This means that we'll try to do a flush in those cases but
we won't necessarily be the last CPU down.  That's not so ideal since
our (lack of) locking assumes we're on the last CPU.

Luckily this isn't as big a problem as you'd think since (at least on
the SoC I tested) we don't get these notifications except on full
system suspend.  ...and on full system suspend we get them on the last
CPU down.  That means that the worst problem we hit is flushing twice.
Still, it's good to make it correct.

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Fixes: 985427f997b6 ("soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches")
Reported-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200504104917.v6.1.Ic7096b3b9b7828cdd41cd5469a6dee5eb6abf549@changeid
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/rpmh-rsc.c