spi: imx: Don't skip cleanup in remove's error path
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 6 Mar 2023 06:57:32 +0000 (07:57 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 20 Mar 2023 13:11:41 +0000 (13:11 +0000)
commit11951c9e3f364d7ae3b568a0e52c8335d43066b5
treea0b9a3ffa4caf3b9538e36f885a00b307ab9af32
parent864f0513a377184e12aa650089c9af71ba36c6e9
spi: imx: Don't skip cleanup in remove's error path

Returning early in a platform driver's remove callback is wrong. In this
case the dma resources are not released in the error path. this is never
retried later and so this is a permanent leak. To fix this, only skip
hardware disabling if waking the device fails.

Fixes: d593574aff0a ("spi: imx: do not access registers while clocks disabled")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230306065733.2170662-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c