vl: use qmp_device_add() in qemu_create_cli_devices()
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 27 Aug 2024 19:27:51 +0000 (15:27 -0400)
committerKevin Wolf <kwolf@redhat.com>
Mon, 25 Nov 2024 10:03:42 +0000 (11:03 +0100)
commit11bf1d6aa06138e93b274e942d6992af63ffc510
tree47512a67f80f2cbdc6501d21f16ba4db4fc8b281
parentbe93fd53723cbdca675bd9ed112dae5cabbe1e91
vl: use qmp_device_add() in qemu_create_cli_devices()

qemu_create_cli_devices() should use qmp_device_add() to match the
behavior of the QMP monitor. A comment explained that libvirt changes
implementing strict CLI syntax were needed.

Peter Krempa <pkrempa@redhat.com> has confirmed that modern libvirt uses
the same JSON for -device (CLI) and device_add (QMP). Go ahead and use
qmp_device_add().

Cc: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20240827192751.948633-3-stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
system/vl.c