wifi: wilc1000: fix multi-vif management when deleting a vif
authorAjay Singh <ajay.kathat@microchip.com>
Mon, 15 Jan 2024 14:56:34 +0000 (15:56 +0100)
committerKalle Valo <kvalo@kernel.org>
Thu, 18 Jan 2024 09:35:14 +0000 (11:35 +0200)
commit12cfc9c8d3faf887a202c89bc312202445fca7e8
tree08420123e7c58c6bbe450e1cf7259f991cecdc17
parenta4f1a05b832e212f8e5b7adcb1b5e8c5c072ae88
wifi: wilc1000: fix multi-vif management when deleting a vif

Adding then removing a second vif currently makes the first vif not working
anymore. This is visible for example when we have a first interface
connected to some access point:
- create a wpa_supplicant.conf with some AP credentials
- wpa_supplicant -Dnl80211 -c /etc/wpa_supplicant.conf -i wlan0
- dhclient wlan0
- iw phy phy0 interface add wlan1 type managed
- iw dev wlan1 del
wlan0 does not manage properly traffic anymore (eg: ping not working)

This is due to vif mode being incorrectly reconfigured with some default
values in del_virtual_intf, affecting by default first vif.

Prevent first vif from being affected on second vif removal by removing vif
mode change command in del_virtual_intf

Fixes: 9bc061e88054 ("staging: wilc1000: added support to dynamically add/remove interfaces")
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Co-developed-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240115-wilc_1000_fixes-v1-5-54d29463a738@bootlin.com
drivers/net/wireless/microchip/wilc1000/cfg80211.c