scsi: bfa: Ensure the copied buf is NUL terminated
authorBui Quang Minh <minhquangbui99@gmail.com>
Wed, 24 Apr 2024 14:44:20 +0000 (21:44 +0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 7 May 2024 01:19:24 +0000 (21:19 -0400)
commit13d0cecb4626fae67c00c84d3c7851f6b62f7df3
tree4065064cd05e366f96534891112a0af29d132617
parentaca061774bc412c1415242f0d2579143dd642b46
scsi: bfa: Ensure the copied buf is NUL terminated

Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from
userspace to that buffer. Later, we use sscanf on this buffer but we don't
ensure that the string is terminated inside the buffer, this can lead to
OOB read when using sscanf. Fix this issue by using memdup_user_nul instead
of memdup_user.

Fixes: 9f30b674759b ("bfa: replace 2 kzalloc/copy_from_user by memdup_user")
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-3-f1f1b53a10f4@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bfa/bfad_debugfs.c