linux-user: NETLINK_LIST_MEMBERSHIPS: Allow bad ptr if its length is 0
authorFrédéric Fortier <frf@ghgsat.com>
Sun, 28 Mar 2021 18:01:35 +0000 (14:01 -0400)
committerLaurent Vivier <laurent@vivier.eu>
Mon, 29 Mar 2021 19:56:18 +0000 (21:56 +0200)
commit13e340c886679fb17df02a35e7d82cb8beb6e9f4
tree8ed216ec42b40f3aeeb7fdb2d5f7bc24909ecfde
parentec2e6e016d24bd429792d08cf607e4c5350dcdaa
linux-user: NETLINK_LIST_MEMBERSHIPS: Allow bad ptr if its length is 0

getsockopt(fd, SOL_NETLINK, NETLINK_LIST_MEMBERSHIPS, *optval, *optlen)
syscall allows optval to be NULL/invalid if optlen points to a size of
zero. This allows userspace to query the length of the array they should
use to get the full membership list before allocating memory for said
list, then re-calling getsockopt with proper optval/optlen arguments.

Notable users of this pattern include systemd-networkd, which in the
(albeit old) version 237 tested, cannot start without this fix.

Signed-off-by: Frédéric Fortier <frf@ghgsat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210328180135.88449-1-frf@ghgsat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
linux-user/syscall.c