media: atmel-isi: Fix crash due to missing subdev in state
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 8 Dec 2023 12:06:37 +0000 (14:06 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 13 Dec 2023 12:21:19 +0000 (13:21 +0100)
commit1545c2b92bdf408e860dea2cf958b65e17a0ce18
tree5a1e0957549df2e03addd899890f74c6ac33553d
parent09b4195021be69af1e1936cca995712a6d0f2562
media: atmel-isi: Fix crash due to missing subdev in state

As a result of converting to the stream-aware state functions, commit
bc0e8d91feec ("media: v4l: subdev: Switch to stream-aware state
functions") caused the sd pointer of the state passed to the
v4l2_subdev_state_get_crop() function to be dereferenced. It however
missed that the atmel-isi driver creates the v4l2_subdev_state instance
on the stack (which it shouldn't do, but that's a separate problem),
without initializing the sd field. This results in a null pointer
dereference.

Fix it by initializing the sd field.

Fixes: bc0e8d91feec ("media: v4l: subdev: Switch to stream-aware state functions")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/atmel/atmel-isi.c