drm/i915/irq: Clear GFX_MSTR_IRQ as part of IRQ reset
authorGustavo Sousa <gustavo.sousa@intel.com>
Wed, 20 Sep 2023 19:53:52 +0000 (16:53 -0300)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 25 Sep 2023 16:04:32 +0000 (09:04 -0700)
commit156adfa55f23620f5817e1cf93dd6f762c8890b4
tree8d95182f7190fdb21180ebcb363d528b2fc0f4f3
parent3447aea1b5e11e4e3734b8b6becde038438d85a2
drm/i915/irq: Clear GFX_MSTR_IRQ as part of IRQ reset

Starting with Xe_LP+, GFX_MSTR_IRQ contains status bits that have W1C
behavior. If we do not properly reset them, we would miss delivery of
interrupts if a pending bit is set when enabling IRQs.

As an example, the display part of our probe routine contains paths
where we wait for vblank interrupts. If a display interrupt was already
pending when enabling IRQs, we would time out waiting for the vblank.

Avoid the potential issue by clearing GFX_MSTR_IRQ as part of the IRQ
reset.

v2:
  - Move logic from gen11_gt_irq_reset() to dg1_irq_reset(). (Matt)

BSpec: 50875, 54028
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230920195351.59421-2-gustavo.sousa@intel.com
drivers/gpu/drm/i915/i915_irq.c