perf/arm-cmn: Fail DTC counter allocation correctly
authorRobin Murphy <robin.murphy@arm.com>
Mon, 11 Dec 2023 19:27:28 +0000 (19:27 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 12 Dec 2023 11:29:21 +0000 (11:29 +0000)
commit1892fe103c3a20fced306c8dafa74f7f6d4ea0a3
treec7467e5461c879f00e9f807e9bfc37182f1e0325
parentf5259997f3e8d6edfcc2daf5b2c0b34f074d7bc0
perf/arm-cmn: Fail DTC counter allocation correctly

Calling arm_cmn_event_clear() before all DTC indices are allocated is
wrong, and can lead to arm_cmn_event_add() erroneously clearing live
counters from full DTCs where allocation fails. Since the DTC counters
are only updated by arm_cmn_init_counter() after all DTC and DTM
allocations succeed, nothing actually needs cleaning up in this case
anyway, and it should just return directly as it did before.

Fixes: 7633ec2c262f ("perf/arm-cmn: Rework DTC counters (again)")
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/ed589c0d8e4130dc68b8ad1625226d28bdc185d4.1702322847.git.robin.murphy@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
drivers/perf/arm-cmn.c