PCI: meson: Remove cast between incompatible function type
authorKrzysztof Wilczyński <kwilczynski@kernel.org>
Thu, 29 Jun 2023 16:59:54 +0000 (16:59 +0000)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Thu, 13 Jul 2023 18:20:31 +0000 (18:20 +0000)
commit1a8bf351ccde7527ca0427151b5fe43f64fa1eac
tree2c1688ec4b25a528471257e524b458a83cca089c
parent06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
PCI: meson: Remove cast between incompatible function type

Rather than casting void(*)(struct clk *) to void (*)(void *), that
forces conversion to an incompatible function type, replace the cast
with a small local stub function with a signature that matches what
the devm_add_action_or_reset() function expects.

The sub function takes a void *, then passes it directly to
clk_disable_unprepare(), which handles the more specific type.

Reported by clang when building with warnings enabled:

  drivers/pci/controller/dwc/pci-meson.c:191:6: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
                                   (void (*) (void *))clk_disable_unprepare,
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
No functional changes are intended.

Fixes: 9c0ef6d34fdb ("PCI: amlogic: Add the Amlogic Meson PCIe controller driver")
Link: https://lore.kernel.org/linux-pci/20230629165956.237832-1-kwilczynski@kernel.org
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/dwc/pci-meson.c