kunit: fix executor OOM error handling logic on non-UML
authorDaniel Latypov <dlatypov@google.com>
Fri, 13 May 2022 18:37:07 +0000 (11:37 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 17 May 2022 16:01:40 +0000 (10:01 -0600)
commit1b11063d32d7e11366e48be64215ff517ce32217
tree98fc3a63aded162a086d8cece4fa1f3ce1b719fc
parent8a7ccad38f8b25c8202efd69371a022357286400
kunit: fix executor OOM error handling logic on non-UML

The existing logic happens to work fine on UML, but is not correct when
running on other arches.

1. We didn't initialize `int err`, and kunit_filter_suites() doesn't
   explicitly set it to 0 on success. So we had false "failures".
   Note: it doesn't happen on UML, causing this to get overlooked.
2. If we error out, we do not call kunit_handle_shutdown().
   This makes kunit.py timeout when using a non-UML arch, since the QEMU
   process doesn't ever exit.

Fixes: a02353f49162 ("kunit: bail out of test filtering logic quicker if OOM")
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/executor.c