ARM: 9123/1: scoop: Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 9 Sep 2021 14:06:52 +0000 (15:06 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 19 Oct 2021 09:30:54 +0000 (10:30 +0100)
commit1c1838757611e2fd3aa798b4a9219f8777f29149
treeb1a34343b5a1d7a9ffd1bfb7651ca21033095f78
parent854f695c3d41853eb7efcd436023c5ab92a257eb
ARM: 9123/1: scoop: Drop if with an always false condition

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so !sdev is never true.

The motivation for this change is to get rid of non-zero return values
for remove callbacks as their only effect is to trigger a runtime
warning. See commit e5e1c2097881 ("driver core: platform: Emit a warning
if a remove callback returned non-zero") for further details.

Link: https://lore.kernel.org/linux-arm-kernel/20210721205450.2173923-1-u.kleine-koenig@pengutronix.de
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
arch/arm/common/scoop.c