qed: Avoid constant logical operation warning in qed_vf_pf_acquire
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 24 Sep 2018 22:17:03 +0000 (15:17 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Sep 2018 03:23:04 +0000 (20:23 -0700)
commit1c492a9d55ba99079210ed901dd8a5423f980487
tree40c9844ebef97a7c8a07d55f69f6a8b6748e9849
parentd4859d749aa7090ffb743d15648adb962a1baeae
qed: Avoid constant logical operation warning in qed_vf_pf_acquire

Clang warns when a constant is used in a boolean context as it thinks a
bitwise operation may have been intended.

drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: warning: use of logical
'&&' with constant operand [-Wconstant-logical-operand]
        if (!p_iov->b_pre_fp_hsi &&
                                 ^
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: use '&' for a
bitwise operation
        if (!p_iov->b_pre_fp_hsi &&
                                 ^~
                                 &
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: remove constant
to silence this warning
        if (!p_iov->b_pre_fp_hsi &&
                                ~^~
1 warning generated.

This has been here since commit 1fe614d10f45 ("qed: Relax VF firmware
requirements") and I am not entirely sure why since 0 isn't a special
case. Just remove the statement causing Clang to warn since it isn't
required.

Link: https://github.com/ClangBuiltLinux/linux/issues/126
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_vf.c