spi: atmel: Do not cancel a transfer upon any signal
authorMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 27 Nov 2023 09:58:41 +0000 (10:58 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 1 Dec 2023 22:19:13 +0000 (22:19 +0000)
commit1ca2761a7734928ffe0678f88789266cf3d05362
treeabd0f9072134c6e4e33f1d670d67f549d9f01f5e
parentb85ea95d086471afb4ad062012a4d73cd328fa86
spi: atmel: Do not cancel a transfer upon any signal

The intended move from wait_for_completion_*() to
wait_for_completion_interruptible_*() was to allow (very) long spi memory
transfers to be stopped upon user request instead of freezing the
machine forever as the timeout value could now be significantly bigger.

However, depending on the user logic, applications can receive many
signals for their own "internal" purpose and have nothing to do with the
requested kernel operations, hence interrupting spi transfers upon any
signal is probably not a wise choice. Instead, let's switch to
wait_for_completion_killable_*() to only catch the "important"
signals. This was likely the intended behavior anyway.

Fixes: e0205d6203c2 ("spi: atmel: Prevent false timeouts on long transfers")
Cc: stable@vger.kernel.org
Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20231127095842.389631-1-miquel.raynal@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-atmel.c