selftests/cgroup: fix clang build failures for abs() calls
authorJohn Hubbard <jhubbard@nvidia.com>
Fri, 3 May 2024 03:51:02 +0000 (20:51 -0700)
committerTejun Heo <tj@kernel.org>
Fri, 3 May 2024 19:06:09 +0000 (09:06 -1000)
commit1da2363228d68da266443e7a85fa91edc2be3dac
treed903bf92b6d2e321f782c2d4f706ffeec2b507a5
parentb7d56d953a67c839a514e382596d5af29b8d6d87
selftests/cgroup: fix clang build failures for abs() calls

First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang is pickier than gcc, about which version of abs(3) to call,
depending on the argument type:

   int abs(int j);
   long labs(long j);
   long long llabs(long long j);

...and this is causing both build failures and warnings, when running:

    make LLVM=1 -C tools/testing/selftests

Fix this by calling labs() in value_close(), because the arguments are
unambiguously "long" type.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/testing/selftests/cgroup/cgroup_util.h
tools/testing/selftests/cgroup/test_kmem.c