mac80211: send ADDBA requests using the tid/queue of the aggregation session
authorFelix Fietkau <nbd@nbd.name>
Thu, 2 Dec 2021 12:45:33 +0000 (13:45 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 14 Dec 2021 10:17:57 +0000 (11:17 +0100)
commit1fe98f5690c4219d419ea9cc190f94b3401cf324
tree8a2b695ca1f53c54b9c99f8d9351e5df0cab9cd8
parent1eda919126b420fee6b8d546f7f728fbbd4b8f11
mac80211: send ADDBA requests using the tid/queue of the aggregation session

Sending them out on a different queue can cause a race condition where a
number of packets in the queue may be discarded by the receiver, because
the ADDBA request is sent too early.
This affects any driver with software A-MPDU setup which does not allocate
packet seqno in hardware on tx, regardless of whether iTXQ is used or not.
The only driver I've seen that explicitly deals with this issue internally
is mwl8k.

Cc: stable@vger.kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20211202124533.80388-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/agg-tx.c