Bluetooth: Fix a buffer overflow in mgmt_mesh_add()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Mon, 12 Dec 2022 13:08:28 +0000 (05:08 -0800)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Tue, 17 Jan 2023 23:50:10 +0000 (15:50 -0800)
commit2185e0fdbb2137f22a9dd9fcbf6481400d56299b
tree10109024e42061c9c3f596951f1faf0401c842a1
parent1f3bd64ad921f051254591fbed04fd30b306cde6
Bluetooth: Fix a buffer overflow in mgmt_mesh_add()

Smatch Warning:
net/bluetooth/mgmt_util.c:375 mgmt_mesh_add() error: __memcpy()
'mesh_tx->param' too small (48 vs 50)

Analysis:

'mesh_tx->param' is array of size 48. This is the destination.
u8 param[sizeof(struct mgmt_cp_mesh_send) + 29]; // 19 + 29 = 48.

But in the caller 'mesh_send' we reject only when len > 50.
len > (MGMT_MESH_SEND_SIZE + 31) // 19 + 31 = 50.

Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Brian Gix <brian.gix@intel.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/mgmt_util.h