KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 13 Jun 2023 06:43:39 +0000 (09:43 +0300)
committerOliver Upton <oliver.upton@linux.dev>
Tue, 13 Jun 2023 12:06:05 +0000 (12:06 +0000)
commit21e87daece5aed25f47f051af5fccbbd39164c88
tree6f2e3cdc5178b37c853bad976c7b3776a9aef808
parentb53d4a27234955810362f91be679afc12e4c3237
KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init()

Smatch detected this bug:
    arch/arm64/kvm/arch_timer.c:1425 kvm_timer_hyp_init()
    warn: missing unwind goto?

There are two resources to be freed the vtimer and ptimer.  The
line that Smatch complains about should free the vtimer first
before returning and then after that cleanup code should free
the ptimer.

I've added a out_free_ptimer_irq to free the ptimer and renamed
the existing label to out_free_vtimer_irq.

Fixes: 9e01dc76be6a ("KVM: arm/arm64: arch_timer: Assign the phys timer on VHE systems")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/72fffc35-7669-40b1-9d14-113c43269cf3@kili.mountain
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
arch/arm64/kvm/arch_timer.c