ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe()
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Tue, 19 Dec 2023 03:07:23 +0000 (05:07 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jan 2024 00:06:28 +0000 (00:06 +0000)
commit222be59e5eed1554119294edc743ee548c2371d0
tree29b96b555830225e2c42936d1d43f38f5a7a243d
parenta4832a94688000662d4ebb8a1c05f086a9c98826
ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe()

Driver uses kasprintf() to initialize fw_{code,data}_bin members of
struct acp_dev_data, but kfree() is never called to deallocate the
memory, which results in a memory leak.

Fix the issue by switching to devm_kasprintf(). Additionally, ensure the
allocation was successful by checking the pointer validity.

Fixes: f7da88003c53 ("ASoC: SOF: amd: Enable signed firmware image loading for Vangogh platform")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Link: https://msgid.link/r/20231219030728.2431640-6-cristian.ciocaltea@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/amd/acp.c