scsi: rdac: Fix send_mode_select retry handling
authorMike Christie <michael.christie@oracle.com>
Wed, 4 Oct 2023 21:00:05 +0000 (16:00 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 13 Oct 2023 20:36:19 +0000 (16:36 -0400)
commit2274bd5e3a2cd4c79a34f19f0d29f1478f9ca0e2
tree2fe8fa3a4aa5fb18a221b9aa6778218c6c5475e7
parent5759a5650d4545231f7a18ae849fd1653dd16c56
scsi: rdac: Fix send_mode_select retry handling

If send_mode_select retries scsi_execute_cmd it will leave err set to
SCSI_DH_RETRY/SCSI_DH_IMM_RETRY. If on the retry, the command is
successful, then SCSI_DH_RETRY/SCSI_DH_IMM_RETRY will be returned to the
scsi_dh activation caller. On the retry, we will then detect the previous
MODE SELECT had worked, and so we will return success.

This patch has us return the correct return value, so we can avoid the
extra scsi_dh activation call and to avoid failures if the caller had hit
its activation retry limit and does not end up retrying.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20231004210013.5601-5-michael.christie@oracle.com
Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/device_handler/scsi_dh_rdac.c