btrfs: avoid starting new transaction when flushing delayed items and refs
authorFilipe Manana <fdmanana@suse.com>
Wed, 26 Jul 2023 15:57:10 +0000 (16:57 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 21 Aug 2023 12:52:18 +0000 (14:52 +0200)
commit2391245ac2875f784335b9148079c6e73639a5f7
treed5d04cbbaffdd576bc3a5ec0c73338c2b28f905f
parented8947bc73aa5bf0ddb5473eafadaa5d740f2f3f
btrfs: avoid starting new transaction when flushing delayed items and refs

When flushing space we join a transaction to flush delayed items and
delayed references, in order to try to release space. However using
btrfs_join_transaction() not only joins an existing transaction as well
as it starts a new transaction if there is none open. If there is no
transaction open, we don't have neither delayed items nor delayed
references, so creating a new transaction is a waste of time, IO and
creates an unnecessary rotation of the backup roots without gaining any
benefits (including releasing space).

So use btrfs_join_transaction_nostart() when attempting to flush delayed
items and references.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/space-info.c